Improve SOPS GPG guide key management #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stealthybox
commented
Mar 3, 2021
stealthybox
commented
- Switch to batch GPG key creation
- Accurately name the cluster's decryption key
- Suggest password-manager backup
- Optionally cleanup secret key from generating machine
- Optionally commit the public key to the repo for team members
- Document SOPS limitations decryption required for editing / appending fields
hiddeco
reviewed
Mar 3, 2021
There was a problem hiding this comment.
Thank you @stealthybox 🥇
Some small suggestions and nitpicks, I probably missed some of the inconsistencies, but you should get the idea.
stealthybox
force-pushed
the
sops-gpg-batch
branch
2 times, most recently
from
415f74a
to
9999053
Compare
stefanprodan
requested changes
Mar 5, 2021
stealthybox
force-pushed
the
sops-gpg-batch
branch
from
9999053
to
ccabe64
Compare
- Switch to batch GPG key creation - Accurately name the cluster's decryption key - Suggest password-manager backup - Optionally cleanup secret key from generating machine - Optionally commit the public key to the repo for team members - Document SOPS limitations decryption required for editing / appending fields Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
Signed-off-by: leigh capili <leigh@null.net>
stealthybox
force-pushed
the
sops-gpg-batch
branch
from
ccabe64
to
d2cdd02
Compare
stefanprodan
approved these changes
Mar 10, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.